Cb 5277 test components #2721
Merged
Cb 5277 test components #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fireEvent.click(linkElement); | ||
|
|
||
| expect(handleClick).toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
please add the case where there is only a href and if you click on it - it leads you with this link
| app, | ||
| ); | ||
|
|
||
| const icon = await waitFor(() => queryByAttribute('href', container, /external-link/i)); |
There was a problem hiding this comment.
searching by className here seems a bit easier than by attribute
|
|
||
| const description = await waitFor(() => getByText('Description Element')); | ||
| expect(description).toBeInTheDocument(); | ||
| }); |
There was a problem hiding this comment.
you can also check in new test case that ripple, big classnames are present here
| const message = 'test_error'; | ||
| const { container, getByTitle } = renderInApp(<StatusMessage message={message} type={ENotificationType.Error} />, app); | ||
| const title = await waitFor(() => getByTitle(message)); | ||
| const icon = await waitFor(() => queryByAttribute('src', container, /error/i)); |
There was a problem hiding this comment.
why not by className?
There was a problem hiding this comment.
if possible please change it everywhere
sergeyteleshev
force-pushed
the
CB-5277-test-components
branch
from
229c337
to
e936194
Compare
Wroud
approved these changes
Jun 24, 2024
sergeyteleshev
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.