Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report #84

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

Askaholic
Copy link
Collaborator

@Askaholic Askaholic commented Jul 27, 2020

Add unit test coverage reporting to the CI build. Because there are some compiled modules, the coverage is recorded on the installed package resulting in coverage paths looking like /path/to/conda/environment/RAiDER/__init__.py. To get a proper coverage report we need to strip off the conda environment part, and replace it with the path to the source code from the repo.

All that's left is to set up coveralls and set the COVERALLS_REPO_TOKEN environment variable in the circleci build.

Closes #80

@Askaholic Askaholic force-pushed the issue/#80-code-coverage branch 12 times, most recently from 3771bf7 to 2408fdf Compare July 27, 2020 23:29
@dbekaert
Copy link
Owner

@jlmaurer @Askaholic Looks above seems to capture it. We are doing an awesome job of 33% code checks! Thats better than 0.

@dbekaert dbekaert self-requested a review July 28, 2020 00:44
Copy link
Owner

@dbekaert dbekaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Askaholic

@dbekaert
Copy link
Owner

@Askaholic Any concern for the last git message in the circleCI build on GIT?

@dbekaert dbekaert marked this pull request as ready for review July 28, 2020 03:44
@dbekaert dbekaert merged commit 6b3958e into dbekaert:dev Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code-coverage though Pytest and coveralls
2 participants