avoids fail on complex structure when logging #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #177 by removing the prepareMessage (JSON.stringify) call when logging The prepareMessage call is still needed for server logging thus complex structure don't working with server logging
This was referenced Feb 13, 2021
respect NGXLogInterface with string type for message do the same processing it used to have for server logging without altering the data for console logging
dbfannin
approved these changes
Feb 22, 2021
|
Still not sure what this change achieves really. What am I missing? |
|
this avoid any fail related to the JSON.stringify call, the console.log do not use it and and it can log "complex structure" without any trouble The JSON.stringify is still used for server logging I'm gonna look into this conflict to fix it |
|
Ok yes, misread the code and thought the change did not achieve that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #177 by removing the prepareMessage (JSON.stringify) call when logging
The prepareMessage call is still needed for server logging thus complex structure don't working with server logging