Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters for surfaceIndexFunction are redundant #3

Closed
dbisdorf opened this issue Apr 26, 2024 · 1 comment
Closed

Parameters for surfaceIndexFunction are redundant #3

dbisdorf opened this issue Apr 26, 2024 · 1 comment

Comments

@dbisdorf
Copy link
Owner

The first parameter to the surfaceIndexFunction callback is the surface type (wall/ceiling/floor); however, this is somewhat redundant. If the face parameter is 1, 2, 3, or 4, we must be asking for a wall; if the parameter is 0, we're asking for a ceiling or floor.

We could eliminate the first parameter (surface type) and simply pass 5 or 6 through the face parameter if we want a ceiling or floor.

@dbisdorf
Copy link
Owner Author

I've updated the library, the example game, and the README for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant