-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make order of rake gem:licenses deterministic #18
Conversation
Thanks for this thoughtful addition. Idea for the title of this PR: |
@olleolleolle Cheers! Yeah, the title could be better, I'll admit. The PR actually does two things:
Happy to change the PR title and |
@edennis Make the change, be happy, and then I'll merge this change, since this change is 💯 |
Before this gets merged, can we think about future proofing this? I am worried that we can end up with 10 options to Rake, where order matters. I'm also worried that tomorrow someone will want a different type of sort and that we're comparing strings. Maybe we can achieve the same results with just adding Otherwise I would want to add a command line tool to this gem and stop recommending using rake (see https://github.com/dblock/frgom for an example) that takes a I am not saying don't merge this PR, just thinking about where to take this. |
62dfd88
to
f5d7d16
Compare
@dblock I can understand your concerns and have adapted the PR to only make the sort order of the +1 to replacing the rake tasks with a CLI. Passing args to rake really leaves a lot to be desired. |
Great, I'm merging this as is. Added #19 to add CLI. This is a nice little project for someone who wants to contribute! |
@dblock Thanks for the offer! I won't make any promises I can't keep but would prefer to pleasantly surprise instead. ;-) In the meantime, do you think there's any chance at cutting the 0.2.2 release? |
Done @edennis |
Hey there! First of all, thanks for publishing these rake tasks as a gem. It's been very useful for maintaining an overview of what software our project is using. In fact, we found it so useful that we've added them to our CI build to automatically check when new dependencies were added or removed and to notify us when this happens. Basically, what we've done is created a list of the licenses by running:
And we've added a check to travis that does a diff between the version-controlled
LICENSES.md
and the current output of the rake task:The problem is that the order of the list isn't stable so we sometimes get false alarms. This PR addresses that and also adds an optional argument to the rake task to choose between alphabetical sorting of the list by license name or by the license count (default).