Added Advanced Stats Module #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the style issues introduced in d02d30a according to the output from rubocop. Details: https://deepsource.io/gh/645engineering/iex-ruby-client/transform/a5303650-f529-49c4-96bf-f3f264cde5cd/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This commit fixes the style issues introduced in 61362de according to the output from rubocop. Details: https://deepsource.io/gh/645engineering/iex-ruby-client/transform/b08e6c74-06ae-406d-beda-bae0a66154bc/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This was referenced Oct 21, 2020
Closed
rodolfobandeira
approved these changes
Oct 21, 2020
|
LGTM. I'm not sure about the deepsource and .env but I'll let more people comment on that |
dblock
requested changes
Oct 21, 2020
The .env construct is pretty common, instead of having to rely on |
|
@dblock Makes sense, just removed the .toml file. Should be good to go. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over orphaned #53.
@dblock I also added dotenv to help with the ENV issue for generating VCRs. I lazily added DeepSource as well to run transformers for me because I forget to locally :)