-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samplegeno & Assorted Fixes (samplegeno-ui-2) #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! (Haven't tested on local / assuming working as expected)
|
||
const { | ||
original_pedigree: { display_title: pedFileName } = {}, | ||
// original_pedigree: { display_title: pedFileName } = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commented this out for the time being... not sure if the pedFileName is necessary anymore? I assume if no one gets upset about this not being visible anymore, it's not necessary.
@@ -612,7 +613,7 @@ const BioinfoStats = React.memo(function BioinfoStats(props) { | |||
: null } | |||
</div> | |||
<div className="col-sm-4">{/* 4,769,578 */} | |||
{ (msaStats.totalVariants && msaStats.totalVariants.value) || "" } | |||
{ (msaStats.totalVariants && msaStats.totalVariants.value) ? decorateNumberWithCommas(msaStats.totalVariants.value): "" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need to do some more work here to make sure these values are always Numbers, not strings. For now, decorateNumberWithCommas
falls back to returning the string value anyway, so worst case scenario, it just doesn't add commas/renders the number as it currently is.
Started as just samplegeno fixes, but it was so small that I lumped in the other updates, too.
Changes:
Samplegeno Table
Filtering Table
gnomad
column. (E.g. 1.20, 0.120. 0.0120, 1.2e-3, 1.2e-4 etc).Case Search Table
case.vcf_file
.Case Bioinformatics Tab
case.vcf_file
's provenance graphTo-Do: