Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perm rm ret props stati #252

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Perm rm ret props stati #252

merged 6 commits into from
Nov 2, 2020

Conversation

aschroed
Copy link
Contributor

@aschroed aschroed commented Nov 2, 2020

Small PR to remove the retired 'role' property from user schema and the 3 old statuses from the status enum.

willronchetti
willronchetti approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, borderline whether or not minor version bump is really needed here but I'm okay with it. You may need to patch some items again to clear out the old statuses though.

@aschroed aschroed merged commit 2cd42f8 into master Nov 2, 2020
@aschroed aschroed deleted the perm_rm_ret_props_stati branch November 2, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti willronchetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschroed @willronchetti