Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Latest Changes #5

Open
kyrstenkelly opened this issue Jan 24, 2020 · 7 comments
Open

Publish Latest Changes #5

kyrstenkelly opened this issue Jan 24, 2020 · 7 comments

Comments

@kyrstenkelly
Copy link

My coworker opened a PR a while back to fix dependencies. It still has not resolved anything on our side because the changes were not published to NPM. Your NPM page still shows that the latest publish was 4 years ago.

Would you kindly publish the dependency updates so we could continue using your package?

@dbox
Copy link
Owner

dbox commented Jan 24, 2020 via email

@dbox
Copy link
Owner

dbox commented Jan 28, 2020

I merged that change in october. Just pushed a new release out.

@dbox dbox closed this as completed Jan 28, 2020
@kyrstenkelly
Copy link
Author

@dbox I don't think your publish to NPM was successful, as your NPM page still says version 0.1.0 and that the latest publish was 4 years ago.

You have to at least bump the version in your package.json before running npm publish.

@dbox
Copy link
Owner

dbox commented Jan 31, 2020

pushed 1.0.1

@dbox dbox reopened this Jan 31, 2020
@dbox
Copy link
Owner

dbox commented Feb 3, 2020

@kyrstenkelly all good?

@kyrstenkelly
Copy link
Author

kyrstenkelly commented Feb 3, 2020

Thanks for doing this @dbox. The version does seem to be properly released now.

I am however getting a new error when trying to use the theme. Not sure if anything else changed since the last release that could've caused this?

Error: SyntaxError: Unexpected token '||' in file /Users/kkelly/git/veritas-design-system/node_modules/sassdoc-theme-flippant/views/documentation/index.html.swig.

@dbox
Copy link
Owner

dbox commented Feb 4, 2020

Hrm. Dunno. Happy to accept a PR fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants