feat: support verify query session info before submit query session #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingchen2222
changed the title
8 tasks
jingchen2222
changed the title
imotai
reviewed
Nov 21, 2022
| Ok(id) => { | ||
| println!("Close Session {}", id); | ||
| Ok((sess_info_node, sess_info_client)) => { | ||
| println!("Close Session Successfully!\nNode session {:?}\nClient session: {:?}", |
There was a problem hiding this comment.
Do not show the debug information to a normal user, you can add a flag or verbose to show it or not
imotai
reviewed
Nov 21, 2022
| @@ -184,8 +185,9 @@ pub async fn process_cmd( | |||
| .close_session(session.as_ref().unwrap().session_id) | |||
| .await | |||
| { | |||
| Ok(id) => { | |||
| println!("Close Session {}", id); | |||
| Ok((sess_info_node, sess_info_client)) => { | |||
imotai
reviewed
Nov 21, 2022
| Stop = 2; | ||
| } | ||
| message QuerySessionInfo { | ||
| // the hex encoded string |
imotai
reviewed
Nov 21, 2022
| @@ -97,21 +109,11 @@ message CloseSessionRequest { | |||
| bytes signature = 2; | |||
| } | |||
| message CloseSessionResponse { | |||
| int32 session_id = 1; | |||
| QuerySessionInfo query_session_info = 1; | |||
There was a problem hiding this comment.
The type of QuerySessionInfo should be bytes
|
close since the pr was merged by #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve #127