Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download arware and get last rollup tx in ar toolbox #533

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Jul 1, 2023

Change

  • Add download arware file
  • support API to get last rollup tx

PR-Codex overview

This PR focuses on adding new functionality and improving error handling for arware operations.

Detailed summary

  • Added ArwareOpError error type.
  • Added ArwareOpError variant to existing error handling code.
  • Added new function download_and_parse_record_batch to download and parse record batches.
  • Added new function get_prev_arware_tx to get the previous arware transaction.
  • Updated existing functions to use ArwareOpError where necessary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jingchen2222 jingchen2222 added the D-dvm-engine dvm engine label Jul 1, 2023
@jingchen2222 jingchen2222 requested a review from imotai July 1, 2023 05:12
@jingchen2222 jingchen2222 self-assigned this Jul 1, 2023
src/storage/src/ar_fs.rs Outdated Show resolved Hide resolved
src/node/src/ar_toolbox.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@imotai imotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #533 (b2eb631) into main (cab7f67) will increase coverage by 1.40%.
The diff coverage is 79.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   54.37%   55.77%   +1.40%     
==========================================
  Files          71       72       +1     
  Lines       13700    14090     +390     
  Branches       61       61              
==========================================
+ Hits         7449     7859     +410     
+ Misses       6251     6231      -20     
Flag Coverage Δ
rust 55.77% <79.95%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/error/src/lib.rs 100.00% <ø> (ø)
src/node/src/rollup_executor.rs 30.94% <57.14%> (+3.79%) ⬆️
src/storage/src/ar_fs.rs 53.65% <65.45%> (+16.70%) ⬆️
src/node/src/ar_toolbox.rs 83.28% <83.28%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imotai imotai merged commit 092e2ed into main Jul 3, 2023
@imotai imotai deleted the feat/support_download_parse_arware branch July 24, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants