Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support apply mutation with docid #557

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Jul 9, 2023


PR-Codex overview

This PR focuses on adding support for document IDs in mutations and improving the recovery process.

Detailed summary

  • Added doc_ids_map field to the MutationHeader message in the db3_mutation_v2.proto file.
  • Modified the apply_mutation method in MutationStore to accept doc_ids_map as a parameter.
  • Updated the apply_mutation method in IndexerNodeImpl and Recover to pass the doc_ids_map to the apply_mutation method in MutationStore.
  • Added functions in MutationUtil to convert document IDs map to a vector and vice versa.
  • Updated the get_create_doc_ids_map function in MutationUtil to handle multiple document IDs.
  • Modified the add_mutation method in MutationStore to handle document IDs.
  • Modified the recover_from_arweave_tx method in Recover to handle document IDs.
  • Modified the fetch_arweave_tx_from_block method in Recover to return a vector of tuples containing the transaction ID and version.
  • Updated the tests to reflect the changes.

The following files were skipped due to too many changes: src/storage/src/db_store_v2.rs, src/node/src/ar_toolbox.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jingchen2222 jingchen2222 requested a review from imotai July 9, 2023 03:23
@jingchen2222 jingchen2222 self-assigned this Jul 9, 2023
Copy link
Contributor

@imotai imotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotai imotai merged commit e7aca6d into main Jul 10, 2023
@imotai imotai deleted the feat/apply_mutation_with_doc_ids branch July 24, 2023 01:07
@imotai
Copy link
Contributor

imotai commented Aug 12, 2023

@qa-agent

1 similar comment
@imotai
Copy link
Contributor

imotai commented Aug 12, 2023

@qa-agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants