Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"next page" should continue numbering #36

Closed
dbrgn opened this issue Oct 25, 2013 · 2 comments
Closed

"next page" should continue numbering #36

dbrgn opened this issue Oct 25, 2013 · 2 comments
Labels
bug
Milestone
Release v0.1.0

Comments

@dbrgn
Copy link
Owner

dbrgn commented Oct 25, 2013

If first page contains 10 items, then the second page (after pressing ) should start counting at 11.
octogene pushed a commit to octogene/orochi that referenced this issue Oct 29, 2013
Add continuous numbering of mixes in results. (refs dbrgn#36)
26e34fe
@octogene
Copy link
Contributor

My commit is a very quick fix for the issue. I don't know if it is what you thought about but i think each page should be cached when displayed or at least there should be a method to find the mix based on the results list number. So even if i'm on page 5 and i look at a mix number in page 1 to 4 i can still play the mix.

dbrgn added a commit that referenced this issue Oct 29, 2013
@dbrgn
Merge pull request #37 from octogene/fixes
7cd5d91 
Fixes for #36 and #37
@dbrgn dbrgn closed this as completed in eca6978 Oct 29, 2013
@dbrgn
Copy link
Owner Author

dbrgn commented Oct 29, 2013

Thanks! There was actually a bug in your implementation (the mix dictionary would get overwritten), but it's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Release v0.1.0
Development

No branches or pull requests
2 participants
@dbrgn @octogene