Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for embedded-hal 1.0 #31

Closed
ShakenCodes opened this issue Oct 31, 2023 · 7 comments · Fixed by #36
Closed

Support for embedded-hal 1.0 #31

ShakenCodes opened this issue Oct 31, 2023 · 7 comments · Fixed by #36

Comments

@ShakenCodes
Copy link
Contributor

ShakenCodes commented Oct 31, 2023

Breaking changes in embedded-hal 1.0.0-rc.1 are incompatible with this driver.
I have a working version at: https://github.com/Radiator-Labs/shtcx-rs, and will submit a PR when the complete build is operational. The driver operates correctly, which I am testomg on an STM32WL55 application.

I am not able to submit the PR at this time, as one of the dev-dependencies, embedded-hal-mock, is not compatible with embedded-hal 1.0.0-rc.1. There is a PR awaiting incorporation, which is tracked by: dbrgn/embedded-hal-mock#86 (Which I now realize is also by you. Thank you for all the goodness!)
linux-embedded-hal is up to the new standard, as of: rust-embedded/linux-embedded-hal#96

@dbrgn
Copy link
Owner

dbrgn commented Nov 1, 2023

Thanks! I reviewed the embedded-hal-mock PR, once it's merged I think I can push a new release 🙂

@dbrgn
Copy link
Owner

dbrgn commented Nov 1, 2023

An updated embedded-hal-mock is now released (0.10.0-rc.1)!

@dbrgn dbrgn changed the title Does not operate with embedded-hal 1.0.0-rc.1 Support for embedded-hal 1.0 Jan 13, 2024
@dbrgn
Copy link
Owner

dbrgn commented Jan 13, 2024

By now the embedded-hal 1.0 stable was released, and embedded-hal-mock also has a release that supports it (0.10.0). It was already updated in #33.

I hope I find time in the coming 1-2 weeks to update the driver. Alternatively, PRs are welcome. (But if you start working on it, please comment here first, so that there is no duplicated effort.)

@ShakenCodes
Copy link
Contributor Author

ShakenCodes commented Jan 13, 2024 via email

@ShakenCodes
Copy link
Contributor Author

Pull request is submitted, but the GitHub Actions do not seem to be starting.

@ShakenCodes
Copy link
Contributor Author

ShakenCodes commented Mar 15, 2024

I am having problems getting this all to work, especially the library's tests. @dbrgn Would you be open to a virtual pairing session to get this over the finish line? (I am in the Pacific time zone and could be available form reasonably early in the morning and well into the evening. My availability starts in the week of March 18, but I thought it would make sense to start planning now.

@dbrgn
Copy link
Owner

dbrgn commented Mar 17, 2024

@ShakenCodes virtual pairing is a bit difficult at the moment, I have quite a full schedule over the next few weeks. what's the main issue you're stuck with?

you could also push your current state, and I could try to pick up from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants