Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest is recommended entry point #23

Merged
merged 3 commits into from
Nov 26, 2017
Merged

pytest is recommended entry point #23

merged 3 commits into from
Nov 26, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 25, 2017

@coveralls
Copy link

coveralls commented Nov 25, 2017

Coverage Status

Coverage increased (+14.9%) to 96.661% when pulling 64df64f on hugovk:patch-2 into de2ac66 on dbrgn:master.

@dbrgn
Copy link
Owner

dbrgn commented Nov 26, 2017

Thanks! It's probably a good idea to remove detailed pinning from test dependencies, but maybe we should still pin the major version?

@hugovk
Copy link
Contributor Author

hugovk commented Nov 26, 2017

Personally I wouldn't bother because I'd like to discover problems sooner, but I have occasionally seen pins something like pytest<=3. Would you like that doing?

@dbrgn
Copy link
Owner

dbrgn commented Nov 26, 2017

Yeah that would be great!

Also, you probably need to rebase against master, as the other PR upgraded pytest already.

@coveralls
Copy link

coveralls commented Nov 26, 2017

Coverage Status

Coverage remained the same at 96.88% when pulling 969fa64 on hugovk:patch-2 into 3effd0f on dbrgn:master.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 26, 2017

Rebased and updated!

@dbrgn dbrgn merged commit 9f2fca3 into dbrgn:master Nov 26, 2017
@hugovk hugovk deleted the patch-2 branch November 26, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants