Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add implementation for test-dbt-installation-docker workflow #67

Conversation

alexander-smolyakov
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov commented Jan 19, 2023

Description:
This PR adds implementation for the test-dbt-installation-docker workflow to test dbt adapters installation via Docker.

Changelog:
test-dbt-installation-docker:

  • Added initial implementation;
  • Updated workflow docs;

test-dbt-installation-main:

  • Added selector to provide an ability to run specific dbt installation tests;

Related issue:

Run examples:

@alexander-smolyakov alexander-smolyakov added the enhancement New feature or request label Jan 19, 2023
@alexander-smolyakov alexander-smolyakov self-assigned this Jan 19, 2023
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to include the version that failed in addition to just the adapter. The slack notification message may. The slack notification message also still suggests this is a failing integration test.

.github/workflows/test-dbt-installation-docker.yml Outdated Show resolved Hide resolved
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kist a small description change then good to merge.

.github/workflows/test-dbt-installation-main.yml Outdated Show resolved Hide resolved
@alexander-smolyakov alexander-smolyakov merged commit bf7a74d into main Jan 23, 2023
@alexander-smolyakov alexander-smolyakov deleted the users/alexander-smolyakov/add-docker-workflow-implementataion branch January 23, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants