fix: use table as default type when building the catalog #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicor88
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix and
thenaturalist
as code owners
svdimchenko
reviewed
Apr 18, 2023
svdimchenko
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Nice job done with extra tests! It seems that get_table_type should be fixed as well because it will fail now with an error
https://github.com/dbt-athena/dbt-athena/blob/284a078da64c83036993b527cf168c42ff02a6cc/dbt/adapters/athena/impl.py#L516
Jrmyy
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This address this issue: #240
There are some edge cases when tables are created by api, where table type is not set, this pr uses a fallback to table in those cases, as it's the best assumption.
Models used to test - Optional
Checklist