Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve get_partition_batches to treat integers properly #425

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Sep 26, 2023

Description

Our functional tests were failing. Specifically, the failures seem due only to cases where we deal with partitions and partitions being integers and it started with dbt-core==1.6.3.

An example of functional tests failing can be found here

In case we one partition that is an integer, adapter.convert_type returns None, not integer, as you can see from here.

This PR treats integers and None types equally - assuming that None types are actually integer.

This issue should be actually fixed in dbt-core, but for now we add this workaround.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 added the enable-functional-tests Label to trigger functional testing label Sep 26, 2023
@nicor88 nicor88 merged commit 64fddef into main Sep 26, 2023
10 checks passed
@nicor88 nicor88 deleted the fix/functional_tests branch September 26, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants