fix: improve get_partition_batches to treat integers properly #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our functional tests were failing. Specifically, the failures seem due only to cases where we deal with partitions and partitions being integers and it started with dbt-core==1.6.3.
An example of functional tests failing can be found here
In case we one partition that is an integer,
adapter.convert_type
returns None, not integer, as you can see from here.This PR treats integers and None types equally - assuming that None types are actually integer.
This issue should be actually fixed in dbt-core, but for now we add this workaround.
Checklist