Fix null column index issue during dbt docs generate
for external tables
#1085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1079
Problem
External tables don't show up in
COLUMN_FIELD_PATHS
metadata. When generating the catalog, these columns were returning null values for external tables.dbt docs generate
does not account for null values for these fields, in particular for the column index.Solution
Coalesce the queried values with default values:
'<unknown>'
1
'<unknown>'
''
The
'<unknown>'
values align with the previous implementation, as does the1
. In the previous implementation, this was implicit, as it was calculated as arow_number
across null fields. In this implementation, it's explicitly1
, as there is really only one field, "the data". The column comment in the original implementation was null in this scenario; this is an attempt to avoid such an error with this field in the future.Checklist