Source for specific tables #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Thank you for putting this together @rahulj51 ! 💪
Nice work putting together the integration tests too.
I've left comments for some very small updates. They are small enough that I will try merging them. I'll reach out to you if I need your help on those.
macros/generate_source.sql
Outdated
| @@ -14,7 +14,7 @@ | |||
|
|
|||
|
|
|||
| --- | |||
| {% macro generate_source(schema_name, database_name=target.database, generate_columns=False, include_descriptions=False) %} | |||
| {% macro generate_source(schema_name, database_name=target.database, table_names=None, generate_columns=False, include_descriptions=False) %} | |||
There was a problem hiding this comment.
Sliding to the end of the signature so that it isn't a breaking change for anyone using positional arguments (rather than keyword arguments):
Suggested change
| {% macro generate_source(schema_name, database_name=target.database, table_names=None, generate_columns=False, include_descriptions=False) %} | |
| {% macro generate_source(schema_name, database_name=target.database, generate_columns=False, include_descriptions=False, table_names=none) %} |
dbeatty10
reviewed
Jun 22, 2022
jeremyholtzman
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Addig another parameter to pass a list of tables to generate_source * Addig another parameter to pass a list of tables to generate_source * Updated README * Updated changelog * Apply suggestions from code review * Update integration_tests/tests/test_generate_source_some_tables.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
maindev/branchdev/branchDescription & motivation
Resolves #50
By default,
generate_sourcegenerates the source definitions for all tables in a schema. With very big schemas, sometimes, you only wish to generate the schema for a selected set of tables. This PR adds an optional arg calledtable_namestogenerate_sourcethat takes a list of tables.Note on Testing
The instructions for testing locally were not clear but with some trial and error, the following steps were performed to run the integration tests
integration_testscreate_source_tableoperation usingrun-operationfrom console.dbt sedto create the...raw_dataschema and thedata__a_relationtable within.Also tested on a real-life dbt project by including the package locally and running the
generate_sourcecommand.Checklist