Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3540] Clean up rpc related code #9359

Open
1 task done
Tracked by #4
emmyoop opened this issue Jan 10, 2024 · 0 comments
Open
1 task done
Tracked by #4

[CT-3540] Clean up rpc related code #9359

emmyoop opened this issue Jan 10, 2024 · 0 comments
Labels
artifacts tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Jan 10, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

dbt-rpc is EOL but there is some code that persists and needs to be cleaned up.

Acceptance criteria

All code for dbt-rpc has been removed

  • rpc node type
  • possibly these artifacts
  • remove tests directly associated with this code
  • all existing test continue to pass

Suggested Tests

No new tests need to be added as this is just removing dead code. Some existing tests may need to be cleaned up.

Impact to Other Teams

None

Will backports be required?

No

Context

This is dead code that just clutters the codebase. We have several "this is rpc - should it be removed" type comments throughout the code that would be nice to clean up.

@emmyoop emmyoop added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jan 10, 2024
@github-actions github-actions bot changed the title Clean up rpc related code [CT-3540] Clean up rpc related code Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

3 participants