Avoid saving secrets in SecretContext #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2022 18:06
|
This draft LGTM overall |
nathaniel-may
requested review from
stu-k,
leahwicz,
gshank and
jtcohen6
and removed request for
a team
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 3, 2022
4 tasks
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 3, 2022
4 tasks
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 3, 2022
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4650
Description
Prevents saving secret environment variables so that partial parsing doesn't get triggered on secret changes.
Checklist
CHANGELOG.mdand added information about my change