-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleting scaffold and create_adater_plugin.py file from scripts section of core as they a… #5117
Conversation
…re either deprecated or will live outside of core
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
@McKnight-42 is this in draft waiting on other PRs to be reviewed first or are we ready to go here with this PR? |
@leahwicz I have it in draft cause we still have some Docs related PRs still up and i figured would be best to have everything as ready to go at once as we can |
@McKnight-42 do we want to delete entirely or leave the script with just a comment and print statement that points to the new repo? |
@nathaniel-may that's a good question, I know we were wanting to make it clear that we didn't want to use the .py file anymore and we link the new scaffold in the changelog, and will have it be whats referenced and pointed to in the docs. but if we feel changing out the file and still having it as a pointer I could be behind that implementation. any thoughts @jtcohen6 @dataders? I pushed up a possible example. |
…nt statement and leave comment that also points to the new scaffold
resolves #
Description
deleting directory and a .py file from core as they are either deprecated or will live outside of core
Checklist