When parsing 'all_sources' should be a list of unique dirs #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
nathaniel-may
approved these changes
Apr 27, 2022
1 task
|
I would be ok backporting this since its a bug and it's a minimal change (most changes are involving test conversion) |
|
Yeah, it's only a couple of lines. I'll backport without the tests. |
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2022
* When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files' (cherry picked from commit f633e99)
gshank
added a commit
that referenced
this pull request
May 16, 2022
…5256) * When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files' (cherry picked from commit f633e99) Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
…5176) * When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files'
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5120
Description
When two (or more) of the "-paths" settings point to the same directory, the "all_sources" method will return duplicate directory names, causing the attempt to parse the same files twice.
Checklist
changie newto create a changelog entry