Support dbt-semantic-interfaces 0.3.0 #8820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8820 +/- ##
==========================================
+ Coverage 86.27% 86.30% +0.03%
==========================================
Files 177 177
Lines 26354 26383 +29
==========================================
+ Hits 22738 22771 +33
+ Misses 3616 3612 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
QMalcolm
requested review from
vadim82 and
ChenyuLInx
and removed request for
a team
MichelleArk
reviewed
Oct 11, 2023
| def upgrade_v10_metric_filters(manifest: dict): | ||
| """Metric filters changed from v10 to v11 | ||
|
|
||
| v10 filters from a serialized manaifest looked like: |
There was a problem hiding this comment.
🕵️ typo: manaifest -> manifest
MichelleArk
approved these changes
Oct 11, 2023
QMalcolm
force-pushed
the
qmalcolm--8819-support-dsi-0.3.0
branch
from
1f3109f
to
5bb084d
Compare
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
Did I caught this PR at a bad time? Seems like the diffs are empty right now |
Regenerating the v10 and v11 test manifest artifacts uncovered an issue wherein we weren't handling disabled metrics that need to get upgraded. This commit fixes that. Additionally, the `upgrade_v10_metric_filters` was getting a bit unwieldy, so I broke extracted the abstracted sub functions.
When we regenerated the v10 test manifest artifact, it started having the `metricflow_time_sine` model, and it didn't previously. This caused `test_backwards_compatible_versions` to start failing because it was no longer identified as having modified state for v10. The test has been altered accordingly
QMalcolm
force-pushed
the
qmalcolm--8819-support-dsi-0.3.0
branch
from
5bb084d
to
3e6cd21
Compare
There was some squash merge weirdness. We've fix it now. Still weird, but less weird. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8819
Problem
We need to use DSI 0.3.0 for 1.7
Solution
Upgrade the dependency on DSI to us 0.3.x versions. Update metric filters and saved query wheres to use new
WhereFilterIntersectionobjectChecklist