Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert test config to data_test config #9191

Closed
wants to merge 1 commit into from
Closed

convert test config to data_test config #9191

wants to merge 1 commit into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 1, 2023

resolves #8698

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Dec 1, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 1, 2023
View reviewed changes
core/dbt/task/test.py Outdated
class TestRunner(CompileRunner):
_ANSI_ESCAPE = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])")

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium test

Suspicious character range that is equivalent to [@A-Z].
core/dbt/task/test.py Outdated
class TestRunner(CompileRunner):
_ANSI_ESCAPE = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])")

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium test

Suspicious character range that is equivalent to \[0-9:;<=>?\].
@emmyoop emmyoop changed the base branch from main to unit_testing_feature_branch December 4, 2023 14:02
@emmyoop emmyoop closed this Dec 4, 2023
@emmyoop emmyoop reopened this Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-3146] [Implementation] updating the unit-tests block (to start with test name instead of model)
1 participant
@emmyoop