Fix: ResourceGrouper no longer considers test resources during access control inference step
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-connors-3
approved these changes
Jul 5, 2023
nicholasyager
deleted the
nicholasyager-limit_resource_types_access_controls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #86
Description
I've created a new class method called
clean_subgraph, which creates a new subgraph that has alltestnodes removed. This allows the_generate_resource_groupto only consider access levels for non-test node connections. This will prevent nodes with only test child nodes from being marked asprivate.A new unit test has been added to confirm functionality.