Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert default psycopg2 back to psycopg2-binary #41

Merged
merged 4 commits into from
Apr 2, 2024
Merged

revert default psycopg2 back to psycopg2-binary #41

merged 4 commits into from
Apr 2, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review March 29, 2024 16:22
mikealfare
mikealfare reviewed Mar 29, 2024
View reviewed changes
pyproject.toml Outdated
# installed via dbt-adapters but used directly
"dbt-common>=0.1.0a1,<2.0",
"agate>=1.0,<2.0",
]
[project.optional-dependencies]
no-binary = ["psycopg2>=2.9,<3.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this locally and I wind up with both psycopg2 and psycopg2-binary instead of just psycopg2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now works.

pip install -e .
  • Installs psycopg2-binary and does not install psycopg2
DBT_PSYCOPG2_NAME=psycopg2 pip install -e .
  • Installs psycopg2 and does not install psycopg2-binary

@colin-rogers-dbt colin-rogers-dbt merged commit 1c95a75 into main Apr 2, 2024
13 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the setBinaryAsDefault branch April 2, 2024 03:07
@dbeatty10 dbeatty10 mentioned this pull request Apr 3, 2024
Closed
3 tasks
mikealfare added a commit that referenced this pull request Apr 4, 2024
@mikealfare
Revert "revert default psycopg2 back to psycopg2-binary (#41)"
bff000f 
This reverts commit 1c95a75
mikealfare added a commit that referenced this pull request Apr 4, 2024
@mikealfare
Revert "revert default psycopg2 back to psycopg2-binary (#41)"
82c4960 
This reverts commit 1c95a75
mikealfare added a commit that referenced this pull request Apr 4, 2024
@mikealfare
Revert "revert default psycopg2 back to psycopg2-binary (#41)"
37e644e 
This reverts commit 1c95a75
@mikealfare mikealfare mentioned this pull request Apr 4, 2024
Closed
mikealfare added a commit that referenced this pull request Apr 4, 2024
@mikealfare
Revert "revert default psycopg2 back to psycopg2-binary (#41)"
96e0aa9 
This reverts commit 1c95a75
@jtcohen6 jtcohen6 mentioned this pull request May 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @mikealfare