Default connect_timeout to None #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
added
the
ready_for_review
sathiish-kumar
approved these changes
May 9, 2023
McKnight-42
approved these changes
May 24, 2023
dbeatty10
approved these changes
May 24, 2023
McKnight-42
added
backport 1.5.latest
and removed
backport 1.5.latest
ready_for_review
This was referenced Jun 2, 2023
mirnawong1
added a commit
to dbt-labs/docs.getdbt.com
that referenced
this pull request
Jun 7, 2023
…timeout (#3456) ## What are you changing in this pull request and why? This PR is to update the docs for the following changes in dbt-redshift: 1. **[Mapping sslmode in psycopg2 to ssl & sslmode in redshift_connector](dbt-labs/dbt-redshift#439 In dbt-redshift 1.5, Python driver switched from psycopg2 to redshift_connector. redshift_connector has both ssl and sslmode parameters, while psycopg2 only has sslmode. We've made changes in dbt-redshift to convert psycopg2' accepted values of sslmode into ssl and sslmode parameters of redshift_connector. This PR explains the conversion logic and includes explanation of the sslmode flag. #3365 2. **[Adding `autocommit` as a parameter](dbt-labs/dbt-redshift#475 Autocommit is a new flag that is defaulted to True. This PR adds explanation of this change and rationale behind this decision in dbt docs #3401 3. **[Connect_timeout default to None](dbt-labs/dbt-redshift#433 Connect_timeout had the default of 10 seconds previously. We changed this default to None. #3460 <!--- Describe your changes and why you're making them. If linked to an open issue or a pull request on dbt Core, then link to them here! To learn more about the writing conventions used in the dbt Labs docs, see the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md). --> ## Checklist <!-- Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable): - [ ] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [ ] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions) --> - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) and [About versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) so my content adheres to these guidelines. - [ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
* change connect_timeout to defaulted None * update test_redshift_adapter to pass new changes * test that connect_timeout parameter is called with the right value * add new changelog --------- Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #427
Description
Change the default of connect_timeout to None. If connect_timeout is not provided in profiles.yml, connect_timeout will be defaulted to None. User can also configure connect_timeout in profiles.yml to the duration of seconds before connection times out.
Checklist
changie newto create a changelog entry