-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-973: Fix issue where materialized views were being mapped as views in catalog queries #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. Otherwise, straightforward. May want to leave a comment about the case
-when
being a short circuit operation though. The important of that precedence of checking the view is materialized first could be lost without that context somewhere.
That's a good point. I chose instead to add the condition in the case statement. Let me know what you think. |
…ws in catalog queries (#653) (#654) * changelog * write test demonstrating the issue * update the catalog query to identify materialized views * explicitly state that materialized views have a relkind of v (cherry picked from commit 99c9d2a) Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
…ws in catalog queries (#653) (#655) * changelog * write test demonstrating the issue * update the catalog query to identify materialized views * explicitly state that materialized views have a relkind of v (cherry picked from commit 99c9d2a) Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
resolves #652, dbt-labs/dbt-core#8864
Problem
Materialized views show up as views in catalog queries.
Solution
Checklist