Expose meta for Metric and SemanticModel #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
approved these changes
Jan 20, 2024
WilliamDee
force-pushed
the
will/add-meta
branch
from
e34e8fc
to
a3c3484
Compare
WilliamDee
changed the title
QMalcolm
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Howdy! Thank you for doing this work @WilliamDee. There are some small changes we need to make before proceeding.
dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json
Outdated
Show resolved
Hide resolved
3 tasks
WilliamDee
force-pushed
the
will/add-meta
branch
from
d54a843
to
c9dbdcc
Compare
WilliamDee
force-pushed
the
will/add-meta
branch
from
c9dbdcc
to
98b3ce6
Compare
|
@QMalcolm this piece should be ready to go! I believe core needs to update that nested config for Metric and we should be able to merge this |
QMalcolm
approved these changes
Feb 27, 2024
4 tasks
courtneyholcomb
added a commit
that referenced
this pull request
Sep 4, 2024
### Description A cleanup item that came up today. Context: #250 (comment) ### Checklist - [ ] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [ ] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [ ] This PR includes tests, or tests are not required/relevant for this PR - [ ] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
4 tasks
DevonFulcher
added a commit
that referenced
this pull request
Nov 12, 2024
### Description This PR is modeled off of [this](#250) prior PR. This PR adds meta to measures, entities, and dimensions. ### Checklist - [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [x] This PR includes tests, or tests are not required/relevant for this PR - [x] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #251
Description
This PR exposes the
metafield for Metric and SemanticModel which enables it to be parsed out in the semantic manifest for use in the SL APIsChecklist
changie newto create a changelog entry