Use common columns for incremental schema changes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
Kayrnt
force-pushed
the
on_schema_change_columns_fix
branch
from
9919be4
to
158e916
Compare
jtcohen6
reviewed
Nov 7, 2021
There was a problem hiding this comment.
This is working well in local testing!
Edit: After reviewing the logic in https://github.com/dbt-labs/dbt-bigquery, and trying a few more configurations, I realize that we'll need slightly different behavior for append_new_columns vs. sync_all_columns. I'll recommend a change in dbt-core accordingly.
Kayrnt
force-pushed
the
on_schema_change_columns_fix
branch
3 times, most recently
from
3185d26
to
0b570e2
Compare
Kayrnt
force-pushed
the
on_schema_change_columns_fix
branch
from
0b570e2
to
1ae2790
Compare
jtcohen6
reviewed
Nov 8, 2021
| @@ -87,6 +87,21 @@ def run_incremental_append_new_columns(self): | |||
| self.list_tests_and_assert(select, exclude, expected) | |||
| self.run_tests_and_assert(select, exclude, expected, compare_source, compare_target) | |||
|
|
|||
| def run_incremental_append_new_columns_remove_one(self): | |||
There was a problem hiding this comment.
Add to test below:
@use_profile('snowflake')
def test__snowflake__run_incremental_append_new_columns(self):
self.run_incremental_append_new_columns()
self.run_incremental_append_new_columns_remove_one()
Kayrnt
force-pushed
the
on_schema_change_columns_fix
branch
from
1ae2790
to
0fea11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#4144
Description
Using dbt-labs/dbt-core#4170 changes, the goal is to retrieve the intersection from existing table columns and the tmp table columns for the condition to avoid referencing columns that wouldn't be in one or the other table and lead to a failure of the incremental run.
BigQuery equivalent: dbt-labs/dbt-bigquery#51
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.