Update connections.py #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issues when the Snowflake OCSP server is not reachable and the dbt user would like to run commands without checking the OCSP server. OCSP failures/inaccessibilitiy are possible due to network routing issues or when corporate network security has exposed Snowflake (especially in privatelink) but not the OCSP server.
Adding changelog information
|
Thanks for reopening the PR @JoshuaHuntley! The change here looks good. I'm just going to close and reopen to trigger tests, now that I've added the |
jtcohen6
reviewed
Nov 17, 2021
There was a problem hiding this comment.
There are a few failing unit tests. To fix, you'll just need to add insecure_mode=False within the mock.call() arguments for each of these tests.
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Updated changelog and unit tests as requested.
jtcohen6
approved these changes
Nov 19, 2021
leahwicz
added a commit
that referenced
this pull request
Dec 3, 2021
* Slack alerts for failed nightly tests (#50) * Fix: Support individual query tag configuration for Seeds and Snapshots (#48) * Add Query Tag for Seed * Add Query Tag for Snapshots * Add Changelog for #48 * Add Snapshot with Query Tag test * Add Seed with Query Tag test * Update connections.py (#49) * Update connections.py Resolves issues when the Snowflake OCSP server is not reachable and the dbt user would like to run commands without checking the OCSP server. OCSP failures/inaccessibilitiy are possible due to network routing issues or when corporate network security has exposed Snowflake (especially in privatelink) but not the OCSP server. * Update CHANGELOG.md Adding changelog information * Update CHANGELOG.md Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> * Update changelog and unit test Updated changelog and unit tests as requested. * Fix typo Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Add column comments to Snowflake views (#53) * Add column comments to Snowflake views * Update create_view_as macro to include column comments * Add test for column-level view comments * Add testing for column comments with non-lowercase column names * Organizing adapter macros for column persistence * Refactor query tag tests (#57) * Refactor query tag tests * Try this * Try storing failures, too * Keep trying * Try it this way * Bumping version to 1.0.0rc2 (#56) * Bumping version to 1.0.0rc2 * Update changelog Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Anton Huck <anthu@users.noreply.github.com> Co-authored-by: R. Joshua Huntley <JoshuaHuntley@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Spencer Taylor <85514383+spencer-taylor-workrise@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to dbt.
resolves #31
Resolves issues when the Snowflake OCSP server is not reachable and the dbt user would like to run commands without checking the OCSP server. OCSP failures/inaccessibilitiy are possible due to network routing issues or when corporate network security has exposed Snowflake (especially in privatelink) but not the OCSP server.
Description
Exposes the insecure_mode option in the Snowflake python connector to dbt via the profile.yml file.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.