Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adap-435 Use explicit begin transaction #887

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shreyadatar
Copy link

resolves #556
docs dbt-labs/docs.getdbt.com/#

Problem

Mixing Snowflake begin/end scripting blocks with transactions throws a syntax error.

Solution

By using the more explicit begin transaction instead of begin, the above confusion and syntax error is avoided, therefore allowing both begin/end blocks as well as transactions being used together.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@shreyadatar shreyadatar requested a review from a team as a code owner January 13, 2024 01:22
@cla-bot cla-bot bot added the cla:yes label Jan 13, 2024
@shreyadatar
Copy link
Author

Hi @colin-rogers-dbt, looks like this failed a few CI checks. Is there a follow-up TODO here?

@lokofoko
Copy link

Any updates here? The issue is still not solved and it is impossible to create a procedure in snowflake from dbt.

@amychen1776
Copy link

@lokofoko Could I ask for your use case for using stored procedures with dbt? Stored procedures are generally anti-pattern to our dbt best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-435] [Bug] Cannot use begin/end scripting statement with snowflake_dml_explicit_transaction
4 participants