Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1074] [Implementation] Remove invalid_insert_overwrite_delta_msg message #962

Closed
3 tasks done
dbeatty10 opened this issue Dec 14, 2023 · 0 comments · Fixed by #963
Closed
3 tasks done

[ADAP-1074] [Implementation] Remove invalid_insert_overwrite_delta_msg message #962

dbeatty10 opened this issue Dec 14, 2023 · 0 comments · Fixed by #963
Labels
enhancement New feature or request tech_debt

Comments

@dbeatty10
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

While researching dbt-labs/docs.getdbt.com#4639, it looks like this code is unused since #700.

So I'd propose we remove it altogether.

Searching both dbt-spark and dbt-databricks didn't yield any other references to invalid_insert_overwrite_delta_msg:

Describe alternatives you've considered

One alternative is to leave it as-is.

It's not hurting anything functionality-wise, but it I was initially confused when reading through the code while researching the behavior of incremental strategies of dbt-spark and dbt-databricks.

Who will this benefit?

Removing unused pieces will make the code easier to read and maintain.

Are you interested in contributing this feature?

No response

Anything else?

No response

@dbeatty10 dbeatty10 added enhancement New feature or request triage tech_debt and removed triage labels Dec 14, 2023
@github-actions github-actions bot changed the title [Implementation] Remove invalid_insert_overwrite_delta_msg message [ADAP-1074] [Implementation] Remove invalid_insert_overwrite_delta_msg message Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech_debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant