Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy to below 2.0 #1053

Closed
wants to merge 4 commits into from
Closed

pin numpy to below 2.0 #1053

wants to merge 4 commits into from

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jun 21, 2024

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

recent nypy release https://pypi.org/project/numpy/2.0.0/ seems to be causing issues with ci/cd

error seen in ci/cd

/databricks/python/lib/python3.7/site-packages/thinc/backends/numpy_ops.pyx in init thinc.backends.numpy_ops()
87: [1130.0s]   
87: [1130.0s]   ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 88 from C header, got 80 from PyObject

Solution

StackOverflow article: https://stackoverflow.com/questions/78650222/valueerror-numpy-dtype-size-changed-may-indicate-binary-incompatibility-expec
pin to below 2.0 release

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Jun 21, 2024
@McKnight-42 McKnight-42 requested a review from a team as a code owner June 21, 2024 16:50
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Jun 21, 2024
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) June 21, 2024 17:06
@McKnight-42 McKnight-42 removed the Skip Changelog Skips GHA to check for changelog file label Jun 21, 2024
@mikealfare mikealfare added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch backport 1.8.latest labels Jun 21, 2024
@mikealfare
Copy link
Contributor

Approved by @amychen1776 for backport to 1.6

auto-merge was automatically disabled June 21, 2024 19:39

Pull request was closed

@mikealfare mikealfare deleted the mcknight/pin-numpy branch July 17, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch backport 1.8.latest cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants