Enhancement/refactor python submission #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
ChenyuLInx
commented
Sep 12, 2022
dbt/adapters/spark/__init__.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| from dbt.adapters.spark.impl import SparkAdapter | |||
|
|
|||
| from dbt.adapters.base import AdapterPlugin | |||
| from dbt.include import spark | |||
| from dbt.include import spark # type: ignore | |||
There was a problem hiding this comment.
Not sure why mypy started to complain things out of no where, just added ignore for now as it has been like this for a long time
McKnight-42
approved these changes
Sep 14, 2022
|
@McKnight-42 Yes, I pulled that function into core in this PR |
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Sep 24, 2022
Resolves #182 ### Description Follows enhancement/refactor python submission in dbt-labs/dbt-spark#452 and dbt-labs/dbt-core#5822.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dbt-labs/dbt-bigquery#248 made it obvious that we should extract more common functions into core.
Checklist
changie newto create a changelog entry