More flexible cluster configuration #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
ChenyuLInx
changed the title
@jtcohen6 @lostmygithubaccount is the current overwriting logic odd? |
gshank
approved these changes
Sep 23, 2022
ChenyuLInx
force-pushed
the
enhancement/job_cluster_run
branch
from
904bbd1
to
37c5377
Compare
ueshin
reviewed
Sep 28, 2022
|
|
||
| @property | ||
| def cluster_id(self) -> str: | ||
| return self.parsed_model.get("cluster_id", self.credentials.cluster_id) |
There was a problem hiding this comment.
@ChenyuLInx I'm updating and testing dbt-databricks, and found out that this is a mistake.
I think this should be:
self.parsed_model["config"].get("cluster_id", self.credentials.cluster_id)
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Sep 28, 2022
### Description Follows "More flexible cluster configuration" at dbt-labs/dbt-spark#467. - Reuse `dbt-spark`'s implementation - Remove the dependency on `databricks-cli` - Internal refactorings Co-authored-by: allisonwang-db <allison.wang@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #444
Description
When using notebook submission, if
job_cluster_configis specified, we will run that model with a job_cluster.This PR also makes user being able to specify a separate
cluster_idorjob_cluster_configfor each individual model through config.job_cluster_configwill overwritecluster_idin current situation.(ifjob_cluster_configis set for a model, we will always use it).This PR also removes the need for
userand put dbt model files under/dbt_python_mode/{$SCHEMA}in Databricks workspaceChecklist
changie newto create a changelog entry