Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DataflowPlanOptimizers for query rendering tests #1263

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Enable DataflowPlanOptimizers for query rendering tests #1263

merged 3 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Enable DataflowPlanOptimizers for query rendering tests 

    The metricflow query rendering tests do snapshot generation and comparison
for standard rendering and optimized rendering. However, these plans only
run the SqlQueryPlanOptimizers - they do not use the DataflowPlanOptimizers.

This means our optimized plans were only partially optimized. Now with
predicate pushdown it would be helpful to see the complete optimization
effect on query plan rendering to SQL.

This change makes that possible by including DataflowPlanOptimizers in
the comparison helper function. For the time being, and to minimize
thrash in snapshot plans, we only include the no-op PredicatePushdownOptimizer.
This will allow us to track the impact of enabling predicate pushdown via
that optimizer through query plan snapshot changes.

A later change will add the branch combiner and update snapshot rendering
accordingly.
    @tlento
    tlento committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    55fda7b View commit details
    Browse the repository at this point in the history

  2. Fix distinct values rendering tests 

    Quick hack to get these working. Note for reviewers, this was less
silly than factoring out the common internal logic in this method
and splitting the entry-point - it's a whole lot of duplication of
mf_test_configuration and stuff no matter what, so we might as well
just jam in this conditional.
    @tlento
    tlento committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ed493d4 View commit details
    Browse the repository at this point in the history

  3. Update snapshots - ID number changes

    @tlento
    tlento committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7ea63ed View commit details
    Browse the repository at this point in the history