-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EnvironmentVariable helper class #722
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This class is doing a whole lot to accomplish very little. In updating the sql engine url environment variable access I noticed the old EnvironmentVariable helper was hardly being used at all anymore. Since most of its usage has disappeared into the sands of time, we remove the last remaining calls - and the class itself - here.
195fa6c
to
76d4aeb
Compare
17114f0
to
b8f190a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class was previously used in the server implementation, so the MFS team might need to move it.
I checked into that, they're not using it at all. |
This class is doing a whole lot to accomplish very little. In
updating the sql engine url environment variable access I noticed
the old EnvironmentVariable helper was hardly being used at all
anymore. Since most of its usage has disappeared into the sands
of time, we remove the last remaining calls - and the class
itself - here.