Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EnvironmentVariable helper class #722

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Aug 15, 2023

This class is doing a whole lot to accomplish very little. In
updating the sql engine url environment variable access I noticed
the old EnvironmentVariable helper was hardly being used at all
anymore. Since most of its usage has disappeared into the sands
of time, we remove the last remaining calls - and the class
itself - here.

Copy link
Contributor Author

tlento commented Aug 15, 2023

@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

This class is doing a whole lot to accomplish very little. In
updating the sql engine url environment variable access I noticed
the old EnvironmentVariable helper was hardly being used at all
anymore. Since most of its usage has disappeared into the sands
of time, we remove the last remaining calls - and the class
itself - here.
Copy link
Contributor

@plypaul plypaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class was previously used in the server implementation, so the MFS team might need to move it.

Base automatically changed from improve-test-convenience to main August 16, 2023 19:50
@tlento
Copy link
Contributor Author

tlento commented Aug 16, 2023

This class was previously used in the server implementation, so the MFS team might need to move it.

I checked into that, they're not using it at all.

@tlento tlento merged commit 62b9145 into main Aug 16, 2023
15 of 16 checks passed
@tlento tlento deleted the remove-environment-variable-helper branch August 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants