Made the project compatible with Qt 5.6 #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -48,7 +48,11 @@ ZipReader::~ZipReader() | |||
|
|
|||
| void ZipReader::init() | |||
| { | |||
| #if QT_VERSION >= 0x050600 | |||
| QVector<QZipReader::FileInfo> allFiles = m_reader->fileInfoList(); | |||
There was a problem hiding this comment.
You don't need to test QT_VERSION. fileInfoList() always returns QVector. It wouldn't be a bad idea to make this const.
There was a problem hiding this comment.
Thank you, mabrand.
- I don't think that fileInfoList always returns a QVector :
/usr/local/Qt-5.5.0/include/QtGui/5.5.0/QtGui/private/qzipreader_p.h
91: QList fileInfoList() const;
/usr/local/Qt-5.6.0/include/QtGui/5.6.0/QtGui/private/qzipreader_p.h
91: QVector fileInfoList() const; - It would indeed be a good idea to make this const.
There was a problem hiding this comment.
Yes, you're right about that. Somehow I overlooked that change.
Open
|
As the author is not active any more, please submit your pull request to https://github.com/VSRonin/QtXlsxWriter I'll take care of maintaining code until the author is back |
|
Thank you. I will try to do that in the next few days. |
rue-ryuzaki
added a commit
to rue-ryuzaki/QtXlsxWriter
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.