Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to highlight edges on hover #12

Closed
gordonwoodhull opened this issue Sep 25, 2015 · 3 comments
Closed

option to highlight edges on hover #12

gordonwoodhull opened this issue Sep 25, 2015 · 3 comments
Labels
enhancement

Comments

@gordonwoodhull
Copy link
Contributor

No description provided.

@gordonwoodhull gordonwoodhull mentioned this issue Sep 25, 2015
Open
@gordonwoodhull
Copy link
Contributor Author

specifically for vizgems viewer, but can be written as a general feature

@gordonwoodhull gordonwoodhull changed the title vizgems viewer: highlight edges on hover option to highlight edges on hover Oct 16, 2015
@gordonwoodhull
Copy link
Contributor Author

there a number of behaviors and a number of interactions you might assign them to: tooltips, selection, highlighting. seems these should be factored as some primitives plus some binding mechanism?

or at least, the choice of behaviors and their bindings should be up to the client, with some simple interface which is probably not d3.selectAll('g.node').on('mouseover', ....) because that's only simple for people who have been so indoctrinated.

@gordonwoodhull
Copy link
Contributor Author

Probably behaviors should be defined exactly that way and packaged as components.

For now, we have highlightNeighbors, edgeHighlightStroke, and edgeHighlightStrokeWidth, but it will be easy to move those out to a separate component in the future.

gordonwoodhull added a commit that referenced this issue Mar 19, 2016
@gordonwoodhull
move highlight-neighbors into a modular "behavior"
d087322 
for #12
gordonwoodhull added a commit that referenced this issue Mar 19, 2016
@gordonwoodhull
remove highlight custom attributes from diagram
8fd2390 
for #12
and whoops, looks like these were breaking some deprecated accessors
gordonwoodhull added a commit that referenced this issue Mar 19, 2016
@gordonwoodhull
maintain neighbor highlights across redraws
b3dc8e7 
for #12

keep highlight state in edge data (could be node data instead?)
always clear or draw on redraw

diagram.child only notify on change
so client must always pass same object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gordonwoodhull