Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with missing values #130

Closed
jeroen opened this issue Feb 24, 2013 · 4 comments
Closed

Dealing with missing values #130

jeroen opened this issue Feb 24, 2013 · 4 comments
Assignees

Comments

@jeroen
Copy link

jeroen commented Feb 24, 2013

There is a big bug in the current version of crossfilter, which causes missing values to be filled in with some random value. See here for an example: http://jsfiddle.net/VgvCB/

@jasondavies fixed this in a branch (see square/crossfilter#3 ) which will hopefully make its way into the master branch soon. For dc.js this means that it should expect the crossfilter grouping to return an additional key-value pair for which the key is null. See here for an example: http://jsfiddle.net/Cr44L/3/.

Perhaps dc should introduce an option for e.g. pie-charts if the null group should be displayed as a separate pie-slice, or if it should be ignored all together. The safest default for all charts is probably to not display the null group?

@NickQiZhu
Copy link
Contributor

Interesting, will definitely do some research on that. The defaults recommended by you sound resonable, will create some test cases to verify this. Hopefully can get this in v1.2 release.

@ghost ghost assigned NickQiZhu Feb 25, 2013
@jeroen
Copy link
Author

jeroen commented Feb 25, 2013

Cool! I would suggest using Jason's branch until it is merged into the official crossfilter master.

@NickQiZhu
Copy link
Contributor

Now I am considering introducing a driver concept to give user full control how crossfilter can be used, also making it possible to support plain series as well as other data mining library. Will try to do it in v1.3 release.

@jrideout
Copy link
Contributor

The crossfilter bug has been addressed. We still might want to tackle this for Nick's non-crossfilter plans, but can track that in another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants