Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_block config for cardano_node source #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tdedgx
Copy link

@tdedgx tdedgx commented Dec 13, 2023

start_block was getting ignored for cardano_node source? check for the config, otherwise use latest from db.

Not tested with Oura as the source

@SebastienGllmt
Copy link
Contributor

This feels reasonable to me, but maybe @gostkin you can check

.start_from(config.start_block)
.await
.context("Can't get starting point from sink")?;
tracing::info!("Passed start_block config: {:?}", config.start_block);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sink.start_from should be called anyway. doesn't matter if start_from is None. otherwise genesis data won't be processed

Copy link
Contributor

@gostkin gostkin Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if start.is_empty() {
genesis::process_genesis(&self.db, &self.network, self.exec_plan.clone()).await?;
return self.get_latest_point().await;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants