Add full input UTXO as part of input context #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ecioppettini
reviewed
Apr 1, 2024
| @@ -69,11 +69,11 @@ WITH | |||
| "Block".era as "era!", | |||
| "Block".height as "height!", | |||
| "TransactionMetadata".payload AS metadata, | |||
| json_agg(DISTINCT "Address".PAYLOAD) input_addresses | |||
| array_agg("TransactionOutput".PAYLOAD) input_utxo | |||
There was a problem hiding this comment.
do we care about the order of these? I think not since inputs are a set, but asking just in case, since there is no way to match these with the inputs in the tx body otherwise.
There was a problem hiding this comment.
yeah we probably should keep them ordered. Although strictly speaking Cardano doesn't enforce an order, this was definitely a mistake in the Cardano infrastructure since it means matching inputs for Plutus is really expensive since you need to do a O(n) scan over all inputs instead of an O(1) lookup for the index you know and we probably shouldn't make the same mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the input content only included addresses which is not enough for the majority of use-cases. This PR switches it to instead provide the full UTXO payload of the input
Note: this is a breaking change