Fix broken tests on master #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems odd that that should be required. Maybe the set_levels! function is the one that should change? |
|
I agree. I wasn't able to track down what commit to DataArrays caused this issue so I didn't open it there. |
|
Should I open an issue over there? |
|
Yes, I think that would be sensible. The type signature on that function is a little strict. |
|
Changes Unknown when pulling fb0f0a1 on tlnagy:pull-request/fb0f0a16 into * on dcjones:master*. |
|
Closing in preference for JuliaStats/DataArrays.jl#201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some array typing problems that broken tests on Gadfly master for months. This should fix #856
@Keno @timholy @darwindarak