-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Update contour usage #867
RFC: Update contour usage #867
Conversation
This API was introduced in v0.1.0, but that version does not work with Julia 0.5. v0.1.1 and up should.
This might also be helpful for #866. |
Running on julia v0.4.6 and using latest master of compose, the test fails (using this PR) here:
The current release of |
The last CI build failed because the new tags for Contour hadn't been merged to METADATA.jl yet; this has happened now (JuliaLang/METADATA.jl#5901) so it might be worthwhile to restart the tests here and see what happens. |
Can you close and re-open to trigger a new build? |
Neat, didn't know I could trigger a restart that way. Now the error seems consistent with what you saw. I'm having some trouble testing this on my work station (running Windows and not being able to find |
append!(contour_xs, xc) | ||
append!(contour_ys, yc) | ||
for _ in 1:length(xc); push!(groups, group); end | ||
push!(levels, Contour.level(level)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this also needs to repeat like you do with groups
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this branch in and made a fix at #870
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I also made a fix on this branch, but if you've already fixed that then this can be ignored.
Changes Unknown when pulling b9f1364 on tlycken:update-contour-usage into * on dcjones:master*. |
This now fails because Edit: merged already. Case closed :) |
I just enabled 0.5 on travis. Tests are running https://travis-ci.org/dcjones/Gadfly.jl/builds/153203929 |
This updates the usage of Contour to the new API introduced v0.1.0, since the old API was removed in a v0.2.0 which is about to be tagged.
I wasn't able to get the tests to pass locally, but I'm not sure it's related to this change; if it is, I don't understand how. If the tests don't pass the CI builds here, I'd be glad for any help in figuring out why.