Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX & TESTS] cleanTags : check if param is undefined. Add 3 test #308

Merged
merged 1 commit into from
Sep 14, 2022
Merged

[FIX & TESTS] cleanTags : check if param is undefined. Add 3 test #308

merged 1 commit into from
Sep 14, 2022

Conversation

juliencastelneau
Copy link
Contributor

@juliencastelneau juliencastelneau commented Sep 14, 2022 •
edited
Loading

@pieper, this PR fixes a test failure due to PR #303

  1. Check if a param is passed in function cleanTags. If not, create it and fill with default value.
    It maintains backwards compatibility for the API.

  2. Add 3 tests demonstrating the ways to use the method

  • force value for a specific tag. Usefull for pseudo-anonymization
  • force a tag to be kept => Remove it in the default array tagNamesToEmpty
  • force a tag to be removed => Add it in the default array tagNamesToEmpty

@pieper pieper mentioned this pull request Sep 14, 2022
Open
pieper
pieper approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@pieper pieper merged commit 77e6362 into dcmjs-org:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieper pieper pieper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliencastelneau @pieper