Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC4: Scenario parsing error #26

Open
minirop opened this issue Feb 20, 2023 · 4 comments
Open

DC4: Scenario parsing error #26

minirop opened this issue Feb 20, 2023 · 4 comments
Labels
game-support Support for games (either formats or the engine) that are not umineko

Comments

@minirop
Copy link

minirop commented Feb 20, 2023

I tried sdu on the game D.C.4 ~ダ・カーポ4~ (title id 0100D8500EE14000), and got an issue with the scenario. Everything else is fine.

$ ./sdu scenario dump-info output/main.snr 
Error: 
 ╺━━━━━━━━━━━━━━━━━━━━┅ Backtrace ┅━━━━━━━━━━━━━━━━━━━━╸

 0: Error: unexpected end of string when reading double-byte char
           While parsing field 'emotion' in BustupInfoItem
     at shin-core/src/format/scenario/info.rs:30
 1: While parsing field 'elements' in SizedTable
     at shin-core/src/format/scenario/info.rs:122
 2: While parsing field 'bustup_info' in ScenarioInfoTables
     at shin-core/src/format/scenario/info.rs:150
 3: While parsing field 'info_tables' in ScenarioHeader
     at shin-core/src/format/scenario/mod.rs:28

 ╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╸
@DCNick3
Copy link
Owner

DCNick3 commented Feb 20, 2023

Wow, I've been trying to actively search for other games using the engine, but this one I haven't seen yet! Thanks for finding that!

Briefly looking at things, the game seems to be using ¿a different way? to store emotion names for bustups. That's what is currently failing with scenario. The bustups themselves do not parse too, seemingly due to the same change.

Also, by experience, some scenario commands are different. The engine version seem to be pretty close to umineko, so probably not much is changed, but there are some game-specific commands that I can see (CHATSET, at least).

This will require some work to implement in sdu (as well as... figuring out a way to define game-specific behaviors 😅)

What is your end-goal with this game? Do you want to create a translation for switch or port the game to some other platform or smth else?

@minirop
Copy link
Author

minirop commented Feb 21, 2023

I was just curious. And found your project whilst looking for a way to extract data.rom.

@DCNick3 DCNick3 changed the title Scenario parsing error DC4: Scenario parsing error Feb 21, 2023
@DCNick3
Copy link
Owner

DCNick3 commented Feb 21, 2023

Hmm, okay, thanks for reaching out then 😄 (I really want to find more games using the engine)

Eventually I hope to support other games using the engine, but, if you do not have a particular project in mind, I don't think there is need to rush support right now

@DCNick3 DCNick3 added the game-support Support for games (either formats or the engine) that are not umineko label Feb 21, 2023
@DCNick3
Copy link
Owner

DCNick3 commented Feb 14, 2024

Just a heads up: I am developing a separate tool focused on translation that allows supporting more games easily and I've just implemented support for DC4

https://github.com/DCNick3/shin-translation-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game-support Support for games (either formats or the engine) that are not umineko
Projects
None yet
Development

No branches or pull requests

2 participants