Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesos input: Decode framework names #55

Merged
merged 1 commit into from
May 1, 2019
Merged

mesos input: Decode framework names #55

merged 1 commit into from
May 1, 2019

Conversation

branden
Copy link

@branden branden commented May 1, 2019

@branden
mesos input: Decode framework names (dcos#54)
5348a2a 
Mesos percent-encodes framework names that are included in metric keys.
See
https://mesos.apache.org/documentation/latest/monitoring/#frameworks.

This commit causes the mesos input plugin to decode framework names
before tagging metrics with them. It also adjusts test cases to cover
framework names with a percent-encoded representation that is different
from its original value.
@branden branden requested review from philipnrmn and gracedo May 1, 2019 01:31
@branden branden merged commit 79bf957 into dcos:1.7.2-dcos May 1, 2019
@branden branden deleted the 1.7.2-decode-framework-name branch May 1, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracedo gracedo gracedo approved these changes

@philipnrmn philipnrmn Awaiting requested review from philipnrmn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@branden @gracedo